This commit has fixes for path partsing and it uses the root for temp files #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@issackelly thanks for the contrib! @alexjg I will let you review since you implemented this part. |
|
This one doesn't address #52 in any meaningful way, we should extract that out of the issackelly:compaction branch. |
This was referenced Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it should at least be configurable where to store the temp files, but the same root as the data directory is safer, as you can't
renamefiles across filesystem types in the way spanreed is doing so now.I am also seeing filenames like this:
Which has 72 characters for the doc id and 64 for the hash. I haven't dug into why yet.
The loading function was also not previously working. The implementation is now functional, if not entirely correct.